Xiyue Deng writes: > Eli Zaretskii writes: > >>> From: Xiyue Deng >>> Cc: rpluim@gmail.com, 72358@debbugs.gnu.org >>> Date: Tue, 13 Aug 2024 15:03:30 -0700 >>> >>> Hi Eli, >>> >>> Eli Zaretskii writes: >>> >>> >> Cc: 72358@debbugs.gnu.org >>> >> From: Xiyue Deng >>> >> Date: Fri, 02 Aug 2024 01:15:22 -0700 >>> >> >>> >> BTW, is there any dev available to commit the changes once it's in a >>> >> good shape? >>> > >>> > All the 3 co-maintainers are tracking these discussions and install >>> > changes that are ready to be installed. >>> >>> It's been a few days since the last time I received feedback for >>> improvements regarding my patches. Is there any other feedbacks/reviews >>> I am expecting from the co-maintainers? Please also let me know when >>> it's time to ask for merging and requesting a new tagged release. >> >> ?? The last message in this discussion was just yesterday evening, and >> my understanding is that you are still discussing the issues and did >> not reach the final conclusion. If I'm mistaken, my apologies; > > The recent communication was not related to my patches but to check > whether it is possible to support outlook.com OAuth2 login (and the > conclusion was no because refreshing access token was disabled as > confirmed by MS representative during an online chat.) > >> please describe your conclusion and post the patch that you-all agree >> would solve the issues, and let's take it from there. > > I actually only received comments from Robert and I have updated my > patches according in [1][2] (also attached in EOM). > > [1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72358#20 > [2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72358#44 Sorry I accidentally hit sent for my previous mail (which actually ended on a full sentence, what are the chances?) To continue, the description of the patches is in the first message[3] and not changed much except the added 6th patch which added a NEWS file. TL;DR the patches include * adding authorization request parameters required for Gmail OAuth2 to work, * updating key calculation in oauth2.plstore to include `client-id' so that it can store multiple accounts for a given service, and * usability and debugging improvements. I haven't received more comments from Robert so I hope the patches now look good to him. Still, I would like to invite for more reviews (if any) and submit the patches when ready. Thanks! [3] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=72358#5 -- Xiyue Deng