Thanks for the comments Eli. Eli Zaretskii writes: >> From: Alvaro Ramirez >> Date: Wed, 9 Oct 2024 18:31:35 +0100 >> Cc: 72272@debbugs.gnu.org, Andrea Corallo , >> Visuwesh >> >> Hi Eli / Stefan >> >> With the latest patch disabling the feature by default, is it >> good to apply? > > It is good, but it no longer applies. Would you please rebase > it on > the latest master branch and resubmit? Yup. Rebased. See latest patch attached. > > Also, please fix the following minor nits while you are at it: > >> ++++ >> +*** New user option >> 'dired-hide-details-hide-absolute-location' > > The heading lines in NEWS should end in a period. > > Also, since this new variable is not documented in the manual, > the > entry should be marked as "---", not "+++". Thanks. Did not know this. >> + (let* ((dir-indent " ") >> + (dir-name (or (car-safe dir-wildcard) >> + (directory-file-name >> (file-name-directory dir)))) >> + (dir-name-point (+ (point) (length >> dir-indent))) >> + (hideable-location (and >> dired-hide-details-hide-absolute-location >> + (not >> (string-empty-p (file-name-nondirectory dir-name)))))) >> + ;; Inserted directory name must be absolute, but >> keep in mind it >> + ;; may be replaced in some instances >> (e.g. dired-build-subdir-alist). >> + (insert dir-indent dir-name ":\n") >> + (when hideable-location >> + (put-text-property dir-name-point >> + (+ dir-name-point >> + (length >> (file-name-directory dir-name))) >> + 'invisible >> 'dired-hide-details-absolute-location))) > > Here (and elsewhere in the patch) please break too-long lines > into > two. Used 80 character limit. Happy to use a different limit if needed. > > Thanks.