On 02/07/2024 01:19, Karl Berry wrote: > I have applied the change on the development branch: > https://git.savannah.gnu.org/cgit/libtool.git/commit/?h=development&id=33be3e965345ffeb49f22190243ea523c637a1bf > > Thanks much. > > Let me know if you would like me to change it. > > It's a minor point, but my suggested wording of > error: argument to -rpath is not absolute: libfoo.lo > feels even clearer to me, since it explains what libtool is parsing > (which is not what the user is intending). > > Also, I didn't realize the error message occurred twice. Given that, I > think the best practice would be to make the two cases have different > wording, so that users/debuggers/maintainers can discern which is being > triggered. (I don't know what the second case is, so I don't have a > suggestion, sorry.) Sorry, I see that I overlooked that. It has been applied now in the attached patch with a rework of the wording for the second case. Here is a reference from the manpage for ld: ``` For compatibility with other ELF linkers, if the -R option is followed by a directory name, rather than a file name, it is treated as the -rpath option. ``` If I understand it correctly, the new wording should be accurate. Let me know what you think. > Okay, I will ask. > > Thanks for that too. --all the best, karl. Here is the relevant commit for why the spacing was added: https://git.savannah.gnu.org/cgit/libtool.git/commit/?h=master&id=eda239d9899e81f616cc34c55c84fd2dddc4f2eb Here is Gary's further explanation: https://github.com/gnulib-modules/bootstrap/issues/33 As I stated in the issue, I do not think there is any good reason to remove the additional spacing, but if you have one, please continue this on the thread in gnulib-modules/bootstrap. -- Ileana Dumitrescu GPG Public Key: FA26 CA78 4BE1 8892 7F22 B99F 6570 EA01 146F 7354