On Thu, Jul 18, 2024 at 05:14:27PM +0200, Ludovic Courtès wrote: > Hi Efraim, > > Ludovic Courtès skribis: > > > Efraim Flashner skribis: > > > >> The first one is with the patches applied, the second one is without the > >> patches. I have the guix-daemon on my pinebook pro to use 3 cores, but > >> I'm not sure how much that would be honored by the grafting code. > >> > >> (ins)efraim@pbp ~/workspace/guix$ sudo sh -c 'echo 3 > /proc/sys/vm/drop_caches' > >> Password: > >> (ins)efraim@pbp ~/workspace/guix$ time ./pre-inst-env guix build libreoffice --check > >> The following graft will be made: > >> /gnu/store/i2aml4p5yg7h090bdzjpaqmds47g26d8-libreoffice-7.6.3.1.drv > >> applying 137 grafts for libreoffice-7.6.3.1 ... > >> grafting '/gnu/store/yd9slkfhdl8lzhhmhm40airimwb6yhj5-libreoffice-7.6.3.1' -> '/gnu/store/1cfjx934czp641v4fmwsz2js7158ivgm-libreoffice-7.6.3.1'... > >> successfully built /gnu/store/i2aml4p5yg7h090bdzjpaqmds47g26d8-libreoffice-7.6.3.1.drv > >> successfully built /gnu/store/i2aml4p5yg7h090bdzjpaqmds47g26d8-libreoffice-7.6.3.1.drv > >> /gnu/store/1cfjx934czp641v4fmwsz2js7158ivgm-libreoffice-7.6.3.1 > >> > >> real 1m35.537s > >> user 0m32.328s > >> sys 0m2.521s > >> (ins)efraim@pbp ~/workspace/guix$ sudo sh -c 'echo 3 > /proc/sys/vm/drop_caches' > >> (ins)efraim@pbp ~/workspace/guix$ time guix build libreoffice --check > >> The following graft will be made: > >> /gnu/store/2f6i7r77z8msbjlspsp0aq5vlpjqnifp-libreoffice-7.6.3.1.drv > >> applying 137 grafts for libreoffice-7.6.3.1 ... > >> grafting '/gnu/store/yd9slkfhdl8lzhhmhm40airimwb6yhj5-libreoffice-7.6.3.1' -> '/gnu/store/xm3q8qsns8qqybq47zvv70n0y0qs4r65-libreoffice-7.6.3.1'... > >> successfully built /gnu/store/2f6i7r77z8msbjlspsp0aq5vlpjqnifp-libreoffice-7.6.3.1.drv > >> successfully built /gnu/store/2f6i7r77z8msbjlspsp0aq5vlpjqnifp-libreoffice-7.6.3.1.drv > >> /gnu/store/xm3q8qsns8qqybq47zvv70n0y0qs4r65-libreoffice-7.6.3.1 > >> > >> real 1m20.573s > >> user 0m29.688s > >> sys 0m2.346s > > > > That’s an 18% slowdown. Could you make several runs to see how stable > > that is? > > Looks like this patch fell through the cracks. > > Maybe we should just go ahead and apply it. Depending on Guile 2.0 for > this isn’t viable in the long term anyway. > > WDYT? Since your email I've been playing with it a bit more. I switched from libreoffice to python since libreoffice isn't built yet for aarch64. Before the patches (ins)efraim@pbp ~/workspace/guix$ sudo sh -c 'echo 3 > /proc/sys/vm/drop_caches' (ins)efraim@pbp ~/workspace/guix$ time ./pre-inst-env guix build python --check The following graft will be made: /gnu/store/b460sh7szir8rf13rjci9cpcbnwgsr04-python-3.10.7.drv applying 16 grafts for python-3.10.7 ... grafting '/gnu/store/qc7n1mflwv12prx185w5wqd95nry5jl1-python-3.10.7-idle' -> '/gnu/store/g3lna24jdg6giddy79kij35kqv9fyr0r-python-3.10.7-idle'... grafting '/gnu/store/vsy0hfgcvrw6fnz53qqqk8ss3c67x2qi-python-3.10.7' -> '/gnu/store/697bsvp9vzj4h6zn3gpgg04h8w36mprl-python-3.10.7'... grafting '/gnu/store/8nj5cwhbfbwb3lf33wsa51rg0v2qbwjb-python-3.10.7-tk' -> '/gnu/store/f051i1aa74z5js30fm4vg4mccsf070w9-python-3.10.7-tk'... successfully built /gnu/store/b460sh7szir8rf13rjci9cpcbnwgsr04-python-3.10.7.drv successfully built /gnu/store/b460sh7szir8rf13rjci9cpcbnwgsr04-python-3.10.7.drv successfully built /gnu/store/b460sh7szir8rf13rjci9cpcbnwgsr04-python-3.10.7.drv successfully built /gnu/store/b460sh7szir8rf13rjci9cpcbnwgsr04-python-3.10.7.drv /gnu/store/g3lna24jdg6giddy79kij35kqv9fyr0r-python-3.10.7-idle /gnu/store/697bsvp9vzj4h6zn3gpgg04h8w36mprl-python-3.10.7 /gnu/store/f051i1aa74z5js30fm4vg4mccsf070w9-python-3.10.7-tk real 0m52.734s user 0m8.821s sys 0m1.489s After the patches (ins)efraim@pbp ~/workspace/guix$ sudo sh -c 'echo 3 > /proc/sys/vm/drop_caches' (ins)efraim@pbp ~/workspace/guix$ time ./pre-inst-env guix build python --check The following graft will be made: /gnu/store/ny03k54s1f0dffn9rywsmf7rd2znsnn5-python-3.10.7.drv applying 16 grafts for python-3.10.7 ... grafting '/gnu/store/qc7n1mflwv12prx185w5wqd95nry5jl1-python-3.10.7-idle' -> '/gnu/store/s6gh2f9fnpsrjhb9arcwvk7ydr2yynd0-python-3.10.7-idle'... grafting '/gnu/store/vsy0hfgcvrw6fnz53qqqk8ss3c67x2qi-python-3.10.7' -> '/gnu/store/w1nk4b8zadnrzd8m8dgfiyhfpm4d2s89-python-3.10.7'... grafting '/gnu/store/8nj5cwhbfbwb3lf33wsa51rg0v2qbwjb-python-3.10.7-tk' -> '/gnu/store/na5an7jrlwvv4ykl5dvmw303dlsavznq-python-3.10.7-tk'... successfully built /gnu/store/ny03k54s1f0dffn9rywsmf7rd2znsnn5-python-3.10.7.drv successfully built /gnu/store/ny03k54s1f0dffn9rywsmf7rd2znsnn5-python-3.10.7.drv successfully built /gnu/store/ny03k54s1f0dffn9rywsmf7rd2znsnn5-python-3.10.7.drv successfully built /gnu/store/ny03k54s1f0dffn9rywsmf7rd2znsnn5-python-3.10.7.drv /gnu/store/s6gh2f9fnpsrjhb9arcwvk7ydr2yynd0-python-3.10.7-idle /gnu/store/w1nk4b8zadnrzd8m8dgfiyhfpm4d2s89-python-3.10.7 /gnu/store/na5an7jrlwvv4ykl5dvmw303dlsavznq-python-3.10.7-tk real 1m22.324s user 0m8.758s sys 0m1.621s There was an unconditional mkdir-p in the graft code that I made check for the directory first (ins)efraim@pbp ~/workspace/guix$ sudo sh -c 'echo 3 > /proc/sys/vm/drop_caches' (ins)efraim@pbp ~/workspace/guix$ time ./pre-inst-env guix build python --check The following graft will be made: /gnu/store/jryp0i86fll06swc856d5njyf4knzw7z-python-3.10.7.drv applying 16 grafts for python-3.10.7 ... grafting '/gnu/store/qc7n1mflwv12prx185w5wqd95nry5jl1-python-3.10.7-idle' -> '/gnu/store/z5zw3f31x7xp71lw9rihkvcf7pmsyz0k-python-3.10.7-idle'... grafting '/gnu/store/vsy0hfgcvrw6fnz53qqqk8ss3c67x2qi-python-3.10.7' -> '/gnu/store/k6kvr48gcjn9z4q3gd51wyddinyxxcw2-python-3.10.7'... grafting '/gnu/store/8nj5cwhbfbwb3lf33wsa51rg0v2qbwjb-python-3.10.7-tk' -> '/gnu/store/gwync0539a5ixgds3k97440zg7miqiq1-python-3.10.7-tk'... successfully built /gnu/store/jryp0i86fll06swc856d5njyf4knzw7z-python-3.10.7.drv successfully built /gnu/store/jryp0i86fll06swc856d5njyf4knzw7z-python-3.10.7.drv successfully built /gnu/store/jryp0i86fll06swc856d5njyf4knzw7z-python-3.10.7.drv successfully built /gnu/store/jryp0i86fll06swc856d5njyf4knzw7z-python-3.10.7.drv /gnu/store/z5zw3f31x7xp71lw9rihkvcf7pmsyz0k-python-3.10.7-idle /gnu/store/k6kvr48gcjn9z4q3gd51wyddinyxxcw2-python-3.10.7 /gnu/store/gwync0539a5ixgds3k97440zg7miqiq1-python-3.10.7-tk real 1m7.380s user 0m8.990s sys 0m1.617s Then I re-enabled n-par-for-each (without exit-on-exception) (ins)efraim@pbp ~/workspace/guix$ time ./pre-inst-env guix build python --check The following graft will be made: /gnu/store/3kr7477zfivxxan5r6ljl81cq3p1j9m8-python-3.10.7.drv applying 16 grafts for python-3.10.7 ... grafting '/gnu/store/qc7n1mflwv12prx185w5wqd95nry5jl1-python-3.10.7-idle' -> '/gnu/store/r9dw90ijwyrzl39yind3iza5bpbcvys2-python-3.10.7-idle'... grafting '/gnu/store/vsy0hfgcvrw6fnz53qqqk8ss3c67x2qi-python-3.10.7' -> '/gnu/store/0zzck57k9321h7lhzlfw5wr87jyqpiv3-python-3.10.7'... grafting '/gnu/store/8nj5cwhbfbwb3lf33wsa51rg0v2qbwjb-python-3.10.7-tk' -> '/gnu/store/v4wg35f62r546hy8f2lbsf51vb8rh0jz-python-3.10.7-tk'... successfully built /gnu/store/3kr7477zfivxxan5r6ljl81cq3p1j9m8-python-3.10.7.drv successfully built /gnu/store/3kr7477zfivxxan5r6ljl81cq3p1j9m8-python-3.10.7.drv successfully built /gnu/store/3kr7477zfivxxan5r6ljl81cq3p1j9m8-python-3.10.7.drv successfully built /gnu/store/3kr7477zfivxxan5r6ljl81cq3p1j9m8-python-3.10.7.drv /gnu/store/r9dw90ijwyrzl39yind3iza5bpbcvys2-python-3.10.7-idle /gnu/store/0zzck57k9321h7lhzlfw5wr87jyqpiv3-python-3.10.7 /gnu/store/v4wg35f62r546hy8f2lbsf51vb8rh0jz-python-3.10.7-tk real 0m55.129s user 0m9.082s sys 0m1.612s I only have 3 cores enabled on my pinebook pro so I can't really comment on weather n-par-for-each does in fact still trigger segfaults in the grafting code, but I haven't seen any. -- Efraim Flashner רנשלפ םירפא GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted