On 10/29/2023 2:41 PM, Dmitry Gutov wrote: > And that's not to mention usage over Tramp (which would be affected by > the +1 process call that you mentioned as well, but that seems > unavoidable). Yeah, I don't see a way around that, unless we constructed a complex command to run via Tramp that does it all in one go. (I looked into using the "--stage" argument for "git ls-files", which gets most of the way to fixing this, but you could break that logic with evil file names not in the tree...) > Anyway, after recent experience micro-optimizing list operations, I came > up with this version where the impact seems minimal. > > WDYT? Thanks, that helped form the basis for the attached patch. It moves the 'member' call into the lambda for the original 'mapcar', and then we can just 'delq' all the nil elements. Benchmarking against the Emacs repo, this still seems to have a minimal perf impact. There might also be a benefit to using "git ls-files --recurse-submodules" when we can (i.e. when not using "-o"), but maybe we can leave that optimization for another day.