Hi Ludo, On Tue, Jul 11, 2023 at 03:51 PM, Ludovic Courtès wrote: > Hi John, > [snip] > Looks like the arguments and snippet are too different to be factorized > via inheritance. However, one could still inherit from the other to > factorize license/synopsis/description? > Yes, thought of that afterwards and made that change locally now. > Apart from this minor issue, LGTM! > I completely forgot there is another patch needed here, one to add freetype-brotli. That is just our freetype package with brotli added as a propagated-input for WOFF font support (if I recall). Attaching the patch now. Actually I think our freetype package should do that as well, but since has nearly 18k dependents that should be grouped with other large changes. I brought this up on guix-devel [0] but didn't get any responses about this change. I think it is not controversial, just how to manage the rebuilds. Perhaps on the next mesa/related branch? [0] Thanks! John