Mauro Aranda <maurooaranda@gmail.com> writes:

> Kévin Le Gouguec <kevin.legouguec@gmail.com> writes:
>
>> Mauro Aranda <maurooaranda@gmail.com> writes:
>>
>>> But, now we don't know if the help-echo property was effectively added
>>> by the library or it was already there :-(.  Sadness.
>>
>> Would the attached address that problem?  (To apply on top of the
>> previous patch; I'll squash it all if we are happy with it)
>
> Looks good to me, thanks.

Alright, here's the squashed patch then - with amended ChangeLog.  Let
me know whether it looks OK to install.


Back to the topic of the warnings-suppress icon representations: FWIW, I
toyed with status/dialog-error-symbolic.svg from adwaita-icon-theme, but
could not land on a result I found perfectly harmonious.

* Edited the SVG to remove the foreground color, as we usually do, so
that faces apply to the inserted image,
* but warnings-suppress inherits from the 'button icon, which means the
image gets the 'icon-face; the result looks messy IMO,
* inheriting from nil instead, buttonize's 'button face takes over,
which is somewhat confusing too,
* adding ':face default' to the image spec makes the result less jarring
(to me).

Attaching that experiment as well FTR; not wholly pleased with it
though.


(I wonder whether this part of the 'button icon…

  (define-icon button nil
    '((image :face icon-button) ; 👈 that one
      ; …
      )
    "Base icon for buttons."
    :version "29.1")

… is desirable.  AFAICT _all_ our in-tree icons inherit from nil instead
of 'button' despite their "button-like" function; wondering to what
extent they are opting out of this ':face icon-button'?)