Po Lu <luangruo@yahoo.com> writes:

Hi Po and thanks for your comments,

[...]

>> +      /* XXX the following permutation is on purpose */
>
> This comment seems redundant.

I have attached a new version of my patch taking your remarks into
account but I did not remove this comment.  I think it could be useful
to understand that "top_gc = something_bottom_gc" is not a typo here.

I have also done the following testing with Xft/cairo/PseudoColor
combinations:

|-------------+-----------------+-----------------+-----------------+---------------------|
|             | Xft + cairo     | Xft only        | cairo only      | None                |
|-------------+-----------------+-----------------+-----------------+---------------------|
| X Truecolor | ok              | ok              | ok              | ok but with a       |
|             |                 |                 |                 | default tiny face   |
|-------------+-----------------+-----------------+-----------------+---------------------|
| Xephyr      | ok but color    | ok but color    | ok but color    | ok, colors ok, but  |
| Pseudocolor | not quite right | not quite right | not quite right | with a default tiny |
|             | around each     | around menu     | around each     | face [fn:2]         |
|             | glyph [fn:1]    | labels [fn:2]   | glyph [fn:1]    |                     |
|-------------+-----------------+-----------------+-----------------+---------------------|

* Footnotes
[fn:1] Aside from the Lucid widget, the emacs buffer is completly
blank.

[fn:2] This time the emacs buffer is here. tool-bar icons are ugly.