>> Two less important side notes:
>> 
>> 1) This patch additionally makes it very straight forward to add support
>>     for ANSI color codes 38 and 48 allowing 256-colors and 24bit
>>     full-color.  I plan to submit such a patch later (for both ansi-color
>>     and term-mode).
>
> Glad to hear it! I was planning on doing this for Emacs 29, but if
> you've already got something in mind for this, feel free to work on
> it. Another thing that might be worth looking at would be improving
> term.el's support for "basic" ANSI escapes; I think it only does bold,
> underline, and inverse. Also, the inverse implementation seems a bit
> over-complicated when it could just use the :inverse-video face
> attribute instead.
>
Ok, thanks. I have actually already prepared patches for all these
features: full-color in ansi-color.el and term.el and also "basic" ANSI
escapes 1-8 for term.el that you mentioned.

I guess there's no harm in sending them right now.

>> 2) Two vector variables, that were recently added by Jim, were merged
>>     into one.  Adding him as CC.
>
> I see you posted an updated patch that doesn't merge these vectors. I 
> don't have an opinion here, although if we do merge them, it would 
> probably be nice to get that into Emacs 28; other packages might 
> conceivably want to let-bind those[1].

Indeed, if we wanted to merge them we'd have to do it in Emacs 28.
That's why I think its best to simply leave them un-merged.

Thanks and best regards.