On Mon, Sep 06 2021, Ludovic Courtès wrote: > Hi, > > Xinglu Chen skribis: > >> On Fri, Sep 03 2021, Ludovic Courtès wrote: >> >>> Hi, >>> >>> Xinglu Chen skribis: >>> >>>> ‘ocaml-ppx-optcomp’ fails to build with the new ‘ocaml-ppxlib’, updating >>>> it makes it build again. >>> >>> In that case, I’d suggest updating both in the same commit, so that each >>> commit contains a working package set. >> >> Or maybe I could reorder the commits so that the ‘ocaml-ppxlib’ update >> comes last? > > Yes, we can do that. > >>> Unfortunately, at least one dependent fails to build: >>> >>> --8<---------------cut here---------------start------------->8--- >>> starting phase `build' >>> File "src/ppx_variants_conv.ml", line 69, characters 22-41: >>> 69 | if Caml.Hashtbl.mem Lexer.keyword_table s >>> ^^^^^^^^^^^^^^^^^^^ >>> Error: Unbound value Lexer.keyword_table >>> command "dune" "build" "@install" "--profile" "release" failed with status 1 >>> builder for `/gnu/store/g73id3dchmqc0dirv9ahzmgbwsyba78b-ocaml-ppx-variants-conv-0.14.1.drv' failed with exit code 1 >>> --8<---------------cut here---------------end--------------->8--- >>> >>> Could you check this one and other packages returned by ‘guix refresh -l >>> ocaml-ppxlib’? >>> >> >> Good catch! There is a patch that should fix this issue[1]; should I >> apply the patch to fix the build? > > Yes please! Let me know when there’s something I should apply. :-) Cool, I will send a revised series soon!