Ludovic Courtès writes: Hello! > Jan Nieuwenhuizen skribis: > >> Ludovic Courtès writes: > > [...] > >> We could add a check for secret-service, possibly here >> >> (define (hurd-vm-disk-image config) >> "Return a disk-image for the Hurd according to CONFIG." >> (let ((os (hurd-vm-configuration-os config)) >> (disk-size (hurd-vm-configuration-disk-size config))) >> (system-image >> (image >> (inherit hurd-disk-image) >> (size disk-size) >> (operating-system os))))) >> >> and/or insert if it it's missing...seems a bit over the top to me? > > Yes, exactly. We could pass ‘os’ through > ‘secret-service-operating-system’, where: > > (define (secret-service-operating-system os) > (operating-system > (inherit os) > (services (cons (service secret-service-type) > (operating-system-user-services os))))) > > (A similar pattern is found in ‘virtualized-operating-system’ and > ‘containerized-operating-system’.) Right, that's nice. I've added this (attached commit) to master. > Thanks for these patches! Happy; thanks for helping! Janneke