Morgan.J.Smith@outlook.com writes:

> From: Morgan Smith <Morgan.J.Smith@outlook.com>
>
> * gnu/packages/mspdebug.scm (mspdebug): New variable.

Can you move this package to gnu/packages/debug.scm instead of adding a
new module?

[...]

> +(define-public mspdebug
> +  (package
> +    (name "mspdebug")
> +    (version "0.25")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/dlbeer/mspdebug.git")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32 "0prgwb5vx6fd4bj12ss1bbb6axj2kjyriyjxqrzd58s5jyyy8d3c"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases (modify-phases %standard-phases (delete 'configure) (delete 'check))
> +       #:make-flags
> +       (let ((target ,(%current-target-system)))
> +         (list (string-append "CC=" (if target
> +                                        (string-append target "-gcc")
> +                                        "gcc"))

Since very recently, you can now use:

  (string-append "CC=" ,(cc-for-target))

instead of the let binding and conditional.

> +               "INSTALL=install"
> +               (string-append "PREFIX=" %output)))))
> +    (inputs
> +     `(("libusb-compat" ,libusb-compat)
> +       ("readline" ,readline)))
> +    (synopsis "Free debugger for use with MSP430 MCUs")

No need to mention free here, since everything in Guix is free
software.  The GitHub tagline is pretty good:

  Debugging tool for MSP430 MCUs

> +    (description "MspDebug supports FET430UIF, eZ430, RF2500 and Olimex
> +MSP430-JTAG-TINY programmers, as well as many other compatible
> +devices.  It can be used as a proxy for gdb or as an independent
> +debugger with support for programming, disassembly and reverse
> +engineering.")
> +    (home-page "https://github.com/dlbeer/mspdebug")
> +    (license gpl2)))

This should be 'gpl2+', since the source files say "GPL 2 or any later
version".

Can you send an updated patch?  Thanks in advance!