Efraim Flashner (2019-12-05 11:02:36 +0200) wrote: > With the 'staging' branch being merged into master the patch no longer > cleanly applies. > > Also, since you've removed a patch from the gnu/packages/patches folder > you need to remove it also from gnu/local.mk. The two other things are > the commit message doesn't list all of the changes and with the new > qt-build-system that would probably be a better choice than wrapping the > binaries yourself, but with an updated patch without that I can help > work on that since it is such a new change. Hi! I'm attaching a reviewed set of patches. The first patch updates the original one to fix the copyright line (so it applies cleanly again), the `local.mk` line removal and commit message completeness. The second patch adds the update to `qt-build-system`. From the comments in `guix/build-system/qt.scm` I gather that no other changes are missing, but I may be wrong. Thanks! -- Ivan Vilata i Balaguer -- https://elvil.net/