tags 35767 + patch
quit

Alex Branham <alex.branham@gmail.com> writes:

> (define-key "l" #'ignore)
>
> Then call:
>
> emacs -Q --eval "(setq byte-compile-error-on-warn t)" -batch -f batch-byte-compile foo.el
>
> it _should_ emit an error since define-key gets called with the wrong
> number of arguments. In Emacs 25.3, it does. In Emacs 26.1 and Emacs
> built recently from git master, it does not.

Specifically, Emacs 26+ doesn't warn about wrong number of arguments to
subrs.  The fix seems simple enough to apply to emacs-26.

Minor caveat, some subrs (e.g., length) get warned about twice (with
slightly different wording each time), but this occurs in 25.3 as well,
so I guess it's acceptable:

    Warning: ‘length’ called with 3 args, but requires 1
    Warning: length called with 3 arguments, but accepts only 1