On Mon 11 Feb 2019 at 09:51, Eli Zaretskii wrote: >> From: Alex Branham >> Date: Sun, 10 Feb 2019 14:37:26 -0600 >> >> I'd like to apply the following patch to enable lexical binding in >> conf-mode.el. > > Can you tell how did you test the result to make sure no bugs will be > introduced by lexical-binding in this package? I see no test suite > for it. Mostly manual testing. conf-mode isn't that complicated; it's mostly dealing with font locking. There are a lot of examples in the docstring though so I've attached a patch that adds some tests based on those. The tests pass for me both before lexical binding and after. I don't need to modify the tests/Makefile.in file to have these run, right? >> OK to apply to master, or should I split the documentation >> changes into a separate commit and apply it to emacs-26? > > The changes to the documentation are too minor to bother splitting > them, IMO. That's what I figured. Just wanted to make since `conf-align-assignments' didn't have documentation before this (well, not that describe-function would report, anyway). >> (conf-align-assignments): >> (conf-quote-normal): >> (conf-mode-initialize): Fix documentation > > There's no file name in this log message, and it is under-filled (did > you use change-log-mode?). Also, our style is to say "Doc fix" or > "Docstring fix" in these cases. Finally, please mention the bug > number in the log message. The file name is in the summary line. Is that not allowed? I was basing it off of ac1e5a5e2ed7c6cf5bec50e5ebf7fab6792230bd which looks similar. Either way, the attached patch should be OK I think.