Hi Ludo, On Sat, 26 May 2018 20:26:20 +0200 ludo@gnu.org (Ludovic Courtès) wrote: > Why is it needed? That would need a comment. :-) dtc has Python bindings and we build them. The u-boot-tools tests use them (nothing else does). I'll add a comment. > Even better if we > can achieve the same effect without defining this search path. Sure, I guess. If you install dtc into your profile it won't work then though. Also, do you think we should try to extract the Python bindings into its own package? > Also no need for the leading slash in ‘files’. Okay. > > + (add-after 'install 'check > > + (lambda* (#:key make-flags test-target #:allow-other-keys) > > + (apply invoke "make" "mrproper" make-flags) > > + (setenv "SDL_VIDEODRIVER" "dummy") > > + (setenv "PAGER" "cat") > > + (apply invoke "make" test-target make-flags) > > + (symlink "build-sandbox_spl" "sandbox") > > + (invoke "test/image/test-imagetools.sh")))))) > > Please return #t. invoke does :) We can add another one, though.