On Sun, 18 Mar 2018 14:05:27 +0100
Julien Lepiller <julien@lepiller.eu> wrote:

> * gnu/packages/java.scm (java-commons-vfs): New variable.
> ---
>  gnu/packages/java.scm | 41 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
> 
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index b8fd30ea5..0ee4ade95 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -9474,3 +9474,44 @@ graphs, and pie charts.")
>  implementation.  It also provides reusable components for client-side
>  authentication, HTTP state management, and HTTP connection
> management.") (license license:asl2.0)))
> +
> +(define-public java-commons-vfs
> +  (package
> +    (name "java-commons-vfs")
> +    (version "2.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> "mirror://apache/commons/vfs/source/"
> +                                  "commons-vfs2-distribution-"
> version "-src.tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32

Snippets:


./commons-vfs2/src/test/resources/test-data/read-tests/dir1/subdir4.jar
./commons-vfs2/src/test/resources/test-data/nested.jar
./commons-vfs2/src/test/resources/test-data/test.jar


> +
> "1cnq1iaghbp4cslpnvwbp83i5v234x87irssqynhwpfgw7caf1s3"))))
> +    (build-system ant-build-system)
> +    (arguments
> +     `(#:jar-name "commons-vfs.jar"
> +       #:source-dir "commons-vfs2/src/main/java"
> +       #:tests? #f; no tests
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'build 'remove-hadoop-and-webdav
> +           ; Remove these files as they are not required and depend
> on difficult
> +           ; packages.
> +           (lambda _
> +             (for-each delete-file-recursively
> +
> '("commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/webdav"
> +
> "commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/hdfs")))))))
> +    (inputs
> +     `(("java-commons-collections4" ,java-commons-collections4)
> +       ("java-commons-compress" ,java-commons-compress)
> +       ("java-commons-httpclient" ,java-commons-httpclient)
> +       ("java-commons-logging-minimal" ,java-commons-logging-minimal)
> +       ("java-commons-net" ,java-commons-net)
> +       ("java-jsch" ,java-jsch)))

I wonder: When do you use "inputs", when "propagated-inputs" for the
ant-build-system? For commons-http-client you used "propagated-inputs".

For antlr3-3.3 there are even both "propagated-inputs" and "inputs".

Otherwise, LGTM.

Björn