Hello Arun, thank you for supporting this patch. Arun Isaac writes: > Thanks for the patch! > > Oleg Pykhalov writes: … >> + (arguments >> + `(#:phases >> + (modify-phases %standard-phases >> + (add-after 'unpack 'chdir-elisp >> + (lambda _ >> + (chdir "misc/emacs")))))) > > It is kinda obvious, but do add a short comment explaining why we are > changing directory. DONE. >> + (synopsis "Emacs major mode for editing Nix expressions") >> + (description "@code{nixos-mode} provides an Emacs major mode for editing >> +Nix expressions.") > > Could you add the following line to the description? > > "It supports syntax highlighting, indenting and refilling of comments." > > I have taken the above sentence from > https://github.com/NixOS/nix/blob/master/misc/emacs/README DONE. >> + (license license:gpl3+))) > > Nix is under the LGPL 2.1 license. So, nix-mode should also be under the > same license, right? DONE. > Could you send an updated patch? Thanks!