Tino Calancha writes: > 1. In my patch `assoc-predicate' is a defsubst. > Should does exit at all? I would inline its call and use `assoc-default' directly, but I guess it's a matter of taste. But wouldn't it be better if `assoc' took an optional testfn? I'm not sure I like the `full' parameter in `assoc-default', and I think the inconsistency of the return values between `assoc' and `assoc-default' is already confusing. Nico