ludo@gnu.org (Ludovic Courtès) writes:

> Hi Kei,
>
> Kei Kebreau <kei@openmailbox.org> skribis:
>
>> * gnu/packages/gnome.scm (gjs): Update to 1.49.1.
>> [source]: Remove snippet.
>> [arguments]: Replace check phase.
>> [propagated-inputs]: Use mozjs-38 instead of mozjs-24; add cairo.
>
> [...]
>
>> -            ;; XXX: fails with:
>> -            ;;   Failed to convert UTF-8 string to JS string: ...
>> -            ;; TODO: actually fix it.
>> -            (substitute* "installed-tests/js/testEverythingBasic.js"
>> -              ((".*test_utf8_inout.*") ""))
>> -            #t)))))
>> +            #t))
>> +         (replace 'check
>> +           (lambda _
>> +             ;; 17 test failures and 3 errors occur for unknown reasons.
>> +             (system* "make" "-k" "check"))))))
>
> Could you try to get more info about the test failures?
>
> It would be good to determine whether these are genuine problems or
> problems caused by our build environment.  Since gjs is quite central in
> GNOME, AIUI, it would be best to have some confidence that it works
> correctly.
>
> Thanks,
> Ludo’.

I'll do my best!