Arun Isaac <arunisaac@systemreboot.net> writes:

> * gnu/packages/backup.scm (obnam)[arguments]: Replace 'check' phase with
>   custom function.

Hi Arun,

Thanks a lot for these! The patches LGTM overall, but will go through
them more thoroughly tomorrow unless someone beats me to it.

> ---
>  gnu/packages/backup.scm | 24 +++++++++++++++++++++++-
>  1 file changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/backup.scm b/gnu/packages/backup.scm
> index 97ab70e65..7e9ae18f3 100644
> --- a/gnu/packages/backup.scm
> +++ b/gnu/packages/backup.scm
> @@ -644,7 +644,23 @@ NTFS volumes using @code{ntfs-3g}, preserving NTFS-specific attributes.")
>           "0qlipsq50hca71zc0dp1mg9zs12qm0sbblw7qfzl0hj6mk2rv1by"))))
>      (build-system python-build-system)
>      (arguments
> -     `(#:python ,python-2))
> +     `(#:python ,python-2
> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +                  (lambda _
> +                    (substitute* "obnamlib/vfs_local_tests.py"
> +                      ;; Check for the nobody user instead of root
> +                      (("self.fs.get_username\\(0\\), 'root'")
> +                       "self.fs.get_username(65534), 'nobody'")
> +                      ;; Disable tests checking for root group
> +                      (("self.fs.get_groupname\\(0\\)") "'root'"))
> +                    (substitute* "obnamlib/vfs_local.py"
> +                      ;; Don't cover get_groupname function
> +                      (("def get_groupname\\(self, gid\\):")
> +                       "def get_groupname(self, gid):  # pragma: no cover"))
> +                    ;; Can't run network tests
> +                    (zero? (system* "./check" "--unit-tests")))))))
>      (inputs
>       `(("python2-cliapp" ,python2-cliapp)
>         ("python2-larch" ,python2-larch)
> @@ -652,6 +668,12 @@ NTFS volumes using @code{ntfs-3g}, preserving NTFS-specific attributes.")
>         ("python2-pyaml" ,python2-pyaml)
>         ("python2-tracing" ,python2-tracing)
>         ("python2-ttystatus" ,python2-ttystatus)))
> +    (native-inputs
> +     `(("gnupg" ,gnupg)
> +       ("python2-coverage" ,python2-coverage)
> +       ("python2-coverage-test-runner" ,python2-coverage-test-runner)
> +       ("python2-pep8" ,python2-pep8)
> +       ("python2-pylint" ,python2-pylint)))
>      (home-page "https://obnam.org/")
>      (synopsis "Easy and secure backup program")
>      (description "Obnam is an easy, secure backup program.  Features
> -- 
> 2.11.0