On Sat, May 28, 2016 at 7:31 PM, Assaf Gordon wrote: > Hello, > > Thank you for the review. > Attached an improved version. > > Regarding when the bug was introduced (in the 'NEWS'), version 3.02 did not support \c escapes, and version 4.0.6 had this bug (as does the first git commit). I wrote: > [bug introduced in the sed-4.0.* releases] Thanks for the quick update! One more thing I noticed is that you use here docs that interpolate. Just as I prefer to use single-quoted strings most of the time, e.g., to avoid having to backslash-escape every backslash, I prefer to use quoted here docs as in the attached. Also, I prefer to space-delimit operators like '<', '<<', and '>'. At least on one side. Also, I removed a stray "EOF" after the final "Exit..." line. Here's the proposed delta, on top of your patch: