Hi, I just pushed the patch on the emacs-25 branch (OK:ed by John). Hopefully, everything should work properly this time. -- Anders On Sat, Nov 14, 2015 at 9:23 PM, David Reitter wrote: > On Nov 14, 2015, at 3:14 PM, Anders Lindgren wrote: > > > David (R), if you think this is a good way to solve this, would you like > to commit this patch, or would you prefer me to do it? > > Yes, defining an extra windowDidBecomeKey function is prettier. > I think that’s okay to check in to master. > > For emacs-25, I think it’s good, too, as it is part of the original > compile bug fix and reduces the chance of future problems rather than > increasing it. I defer to John Wiegley (cc’ed) regarding this. > > Anders, I do think that the cleaner way would be to use notifications to > run these functions, which might reduce extra calls. However, that > requires more testing that I was willing to do (on GNUStep too), because > there’s potential for these methods getting called at a later point in time. > > - David