On 05/06/15 20:27, Eric Blake wrote:
> On 06/05/2015 11:53 AM, Pádraig Brady wrote:
>> On 05/06/15 17:02, Michael Felt wrote:
>>>> Attribute "constructor" is not supported
>>
>> Does the attached patch help?
>>
> 
>> +++ b/configure.ac
>> @@ -455,7 +455,11 @@ if test $gl_cv_list_mounted_fs = yes && test $gl_cv_fs_space = yes; then
>>  fi
>>  
>>  AC_MSG_CHECKING([whether this is system supports stdbuf])
>> -AC_COMPILE_IFELSE(
>> +ac_save_CFLAGS="$CFLAGS"
>> +# Build with -Werror to detect warnings about
>> +# about ignored "constructor" arguments.
>> +CFLAGS="$CFLAGS -Werror"
> 
> -Werror works for gcc and some other compilers like clang, but is not
> universal to all compilers.  Are you sure that it is the right flag to
> be adding for the duration of this test?

Yes good point.

Also it's best only worry about warnings when cross compiling,
as otherwise we're using a direct runtime check.
Updated patch is attached.

thanks,
Pádraig.