On 12/09/2024 4:49, Po Lu wrote: > Thanks. Following are a number of minor stylistic comments. Sorry I missed those. They are corrected in the attached patch. > Lastly, I observe that you have implemented a bespoke dialog parser for > Windows, the likes of which have been a source of difficulties in the > past. Is there any particular reason that you decided against > implementing the w32_dialog_show function called in the "#ifdef > HAVE_DIALOGS" version of w32_popup_dialog? I left w32_dialog_show as it was in case an implementation for older versions of windows became available. I can rewrite it if you think is better that way.