Hi Jim,

Jim Meyering <jim@meyering.net> writes:

> Regarding the support for configurable colors, as already mentioned
> here, we really do want to avoid adding support for any more
> environment variables.  Would you please adjust the second
> patch to take the settings from a command line argument instead?
> With that, it will be trivial to add an envvar-honoring wrapper script,
> function or alias, for those who desire that convenience.
>
> The most important reason not to provide this functionality via
> an envvar is that it would then allow that envvar setting to alter
> the behavior of any program that invokes diff, and that sort of
> interaction is often surprising and undesirable.
>
> Thanks again for contributing!

Thanks for your review.

Would something like this patch work?

I have attached the difference from the previous version to make the
review easier as few lines are changed.

I have included the full ChangeLog entries in the commit message so it
will be easier to squash the patch on top of the previous one.

Regards,
Giuseppe