On Monday 05 of October 2015 00:45:50 Pavel Raiskup wrote: > > should we test the size of the string first ? i've written such raw shell > > string parsing functions before, and once you hit a certain size (like 1k+ > > iirc), forking out to sed is way faster, especially when running in multibyte > > locales (like UTF8) which most people are doing nowadays. > > -mike > > Well, that optimization would require (fast) strlen()-like construct. > Anyway, the vast majority of calls to func_quote () function will have > short ARG, and its complexity is still "just" linear. We could optimize > later if that was a real issue. > > I would like to propose solution based on Eric's one, without using of > '${VAR%.}' and '${VAR#.}' constructs -- sounds like this could be even > more portable while it keeps almost the same speed (if we can use += its > even faster). > > I have yet a another patch trying to minimize option-parser overhead > (that is focused on the POV of Richard, but that needs to be cleaned up a > bit, I'll post hopefully tomorrow). > > Any comment is welcome! Re-attached (fixes for 'make syntax-check' and fixed one comment). Pavel