On 27/01/15 10:48, Giuseppe Scrivano wrote:
> Pádraig Brady <P@draigbrady.com> writes:
> 
>> thanks!
>> Pádraig.
> 
> Thanks for the review, I've amended the changes you suggested:

There were a few problems:

 - Compile failure without HAVE_SYNCFS (defined)
 - Various errors() used errno where undefined
 - A file that failed to sync was not identified
 - File descriptors were leaked on failure to sync
 - The command would block if presented with a fifo
 - Write only files ere not supported
 - Various references to "paths" rather than "files"
 - The info docs for --file-system were a bit terse
 - No tests

I've fixed up those issues in the attached,
which I'll push soon.

thanks,
Pádraig.