On 04/03/2014 07:29 AM, Paul Eggert wrote: > Pádraig Brady wrote: >> The code looks good. > > Thanks for the review. I installed the patch and am marking this bug as done. A test needs an adjustment also due to assuming that writing to an empty file was a valid thing for shred to be doing. The attached should fix it up. thanks, Pádraig.