On 06/20/2014 01:23 AM, Bernhard Voelker wrote:
> On 06/18/2014 07:21 PM, Pádraig Brady wrote:
>> The attached 2 patches on top of current master,
>> should address your suggested tweaks and above ordering issue.
> 
> Thanks. Both patches look good.
> 
> The whole story is already rather long, so I almost don't dare
> to come up with it ... but there is one last issue left with
> eclipsed file systems:
> 
>   $ mount /dev/sda5 /mnt
> 
>   $ src/df /mnt
>   Filesystem     1K-blocks   Used Available Use% Mounted on
>   /dev/sda5      206424760 440500 195482116   1% /mnt
> 
>   $ mount -o loop tmp.img /mnt
> 
>   $ src/df /mnt        # correct: search by mount point
>   Filesystem     1K-blocks  Used Available Use% Mounted on
>   /dev/loop0         59365  1308     53471   3% /mnt
> 
>   $ src/df /dev/sda5   # wrong: search by device
>   Filesystem     1K-blocks  Used Available Use% Mounted on
>   /dev/sda5          59365  1308     53471   3% /mnt

Fingers crossed this is the last df issue.
df is getting quite messy and could do with a refactoring
to use prepopulate hashes from /proc/self/mountinfo,
but not for this iteration at least.

Proposed test attached.

thanks,
Pádraig.