On 04/16/2014 02:51 PM, Guilherme de Almeida Suckevicz wrote:
> Hi Pádraig,
> 
> I made a patch for this issue according to the tips above.
> I hope that is ok!
> 
> [guilherme@almeida build]$ diff ../src/ls.c ../src/ls-orig.c

Note the patch is reversed, also we prefer unified format,
also we'd much prefer a patch against the git repo.
For general notes on supplying patches see:
http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=blob;f=README-hacking;hb=HEAD

> 2372,2382c2339
> <     {
> <       /* If COLORTERM is not set, check if the term type is know. */
> <       if (getenv ("COLORTERM") == NULL)
> <     {
> <       if (! know_term_type ())
> <         {
> <           print_with_color = false;
> <           return;
> <         }
> <     }

          you want a return here too

> <     }

I've cleaned up the patch and added a test.
If you're Ok with it I'll push.

thanks,
Pádraig.