Hi Andy, Andy Wingo writes: > Looks like a good start. Two comments: > > On Mon 01 Apr 2013 23:27, Mark H Weaver writes: > > 1. I don't much like the addition of this call to this inline function. > Can we move all the non-fast-path code into some other function? That > would include the flush call as well. Good idea! I've posted separate patches to do that here: "[PATCH] Move slow path out of 'scm_get_byte_or_eof' et al" http://lists.gnu.org/archive/html/guile-devel/2013-04/msg00032.html > 2. I think we probably need some tests. I've attached a new patch which adds tests. Note that this patch depends upon the "Move slow path out" patches referenced above. More thoughts? Thanks! Mark