On 01/05/2012 10:54 PM, Peter Rosin wrote:
> Hi!
>
Hi Peter, and thanks for your relentless testing on MinGW/MSYS.

> I tried make check on MSYS with the current master, and among other
> things, this problem stands out as it FAILs so many test cases.
> 
> I'm using tap-bailout-w.test as an example, no use reporting the
> same problem 80+ times, right :-)
> 
> The perl version is 5.8.8
> 
> Here's tap-bailout-w.log:
> 
> ./tap-bailout-w.test: will source ./tap-bailout.test
> Running from installcheck: no
> Using TAP: no
>
> [SNIP]
>
> ++ TESTS='a.test b.test c.test d.test e.test'
> ++ make -e check
> Can't locate TAP/Parser.pm in @INC (@INC contains: /usr/lib/perl5/5.8/msys /usr/lib/perl5/5.8 /usr/lib/perl5/site_perl/5.8/msys /usr/lib/perl5/site_perl/5.8 /usr/lib/perl5/site_perl/5.8 /usr/lib/perl5/vendor_perl/5.8/msys /usr/lib/perl5/vendor_perl/5.8 /usr/lib/perl5/vendor_perl/5.8 .) at ./tap-driver line 33.
> BEGIN failed--compilation aborted at ./tap-driver line 33.
> make[2]: *** [a.log] Error 2
> make[1]: *** [check-TESTS] Error 2
> make: *** [check-am] Error 2
>
Bummer.  I had taken for granted that all perl installations modern enough
to correctly run automake also came with a built-int TAP::Parser module --
but it seems this is not the case after all.

Anyway, since the perl implementation of the TAP driver is meant to be
used only for prototyping and consistency checks (the "real" TAP driver
being the portable one implemented in awk), this is not a big deal, and
we just need to skip the affected tests on systems lacking TAP::Parser.

Could you verify that the attached patch solves the issue?  I've tested
it by putting a broken TAP::Parser early in @INC, so it should work; but
as you know there is no substitute to testing with the "real thing".

Thanks,
  Stefano